On the dock. I read here that you discussed it a little bit about not being able to theme it while I was on holidays. Do you mind describing a little bit more the issue?
There is an option which we keep to false “org.gnome.shell.extensions.dash-to-dock apply-custom-theme”. I looked at the code, this only adds “dashtodock” class to the dock itself to differientate from the dash one, which could be used in the general Shell theme.
So, I would be in favor to do most of the changes in the themes (in term of maintainability), and if someone should be done in the theme and couldn’t, we talk to upstream about adding the correct class to support it.
Am I missing anything?
That’s maybe the issue you were seeing: dashtodock has its own css file shipped in the theme (this is how “shrink” and others properties are different: they just change the class name and apply the new style thus). This css files is applied last for the theme, and it seems it overrides the general theme thus.
I would propose to remove this css file in our fork and just implement that in the general theme, wdyt? (/!\ it means I need to upload this modified dash to dock in the ppa and keep it up to date or find a clever way to change this on the per session stuff…).
It means that we will port all properties from stylesheet.css to the general theme, which is a better place for this particular use case IMHO (and let also other theme creators style it).
I’m not sure to get what you mean here. I don’t see any inner shadow between elements?
The dark square (I guess when you select an element) can surely be styled once the restriction above is lifted.
hiding mechanism: that’s indeed a little bit more tricky. However, it looks better on my ubuntu session than apparently for you, note the transparency + shadow. See the bottom and top icons:
The default is shrinked (from your screenshot, it’s not enabled apparently), so giving less space to icons. We can change default icon size (I always set them to 32px personnally). However, IIRC, the 48px default was selected based on user testing.
Indicator position, size and spacing should be able to be changed via css.
Same, should be doable with a :first-child css class.
So, it seems that overall, all requests can be changed without any code modifications, just ensuring the css file doesn’t override the shell theme, am I right?
As a first approach, we can directly patch the css file
/firstname.lastname@example.org/stylesheet.css if you want to ensure this is doable